Update getting started section to include npm install #37016
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you currently follow the getting started section step by step the first thing you are getting is an error that he node modules are not installed. This of course is the case, but I believe it might be more frictionless for first time contributors when every step is included in the list.
Member
|
When I run The install-if-deps-outdated script does that. Also, the right install command is What errors are you getting when running |
Contributor
Author
|
Okay found my error. Had version 12.5.0 of node running node: 12.5.0
Error: Wanted node version ^10.16.3 (>=10.16.3 <11.0.0)
To install node, run `nvm install ^10.16.3` or see https://nodejs.org/ |
Member
|
@fabiankaegy We are working on the Node 12 upgrade in #37031. You can help testing or make some other contribution, if you're interested. Also, maybe we can improve the experience by better error messages, so that it's more obvious what is the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you currently follow the getting started section step by step the first thing you are getting is an error that he node modules are not installed.
This of course is the case, but I believe it might be more frictionless for first time contributors when every step is included in the list.
Changes proposed in this Pull Request